rusackas opened a new pull request, #45609: URL: https://github.com/apache/superset/pull/45609
### SUMMARY The Chromatic workflow built its own `superset-node-ci` image on every run, in parallel with the Frontend workflow building the identical image and sharing it with its six jobs as an artifact. On a warm layer cache that's about 50 seconds of duplicate work; after a lockfile or workspace manifest change it's 7 minutes (417 s on #45603's run), which is exactly when you want the visual check back quickly. This moves Chromatic into the Frontend workflow as a `chromatic` job that `needs: frontend-build`, downloads the `docker-image` artifact and loads it, the same way `test-storybook` does, then builds Storybook in that container and publishes with the same `chromaui/action` pin and options. The standalone `chromatic.yml` goes away. The token guard for forks is unchanged (every step is skipped when `CHROMATIC_PROJECT_TOKEN` is empty), the job keeps `pull-requests: write` for the Chromatic status, and its checkout keeps the 500-commit depth TurboSnap's `onlyChanged` relies on. The job is added to the `actions-timeline` list so it shows up in the timeline. The old workflow's `paths: superset-frontend/**` filter is covered by `frontend-build`'s change detector, which gates every job in this workflow. Note for merging: #45606 edits `chromatic.yml` (removing an `npm i`), and this PR deletes the file, so whichever lands second needs a trivial rebase. I'll handle it. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF N/A ### TESTING INSTRUCTIONS The `chromatic` job on this PR should publish to Chromatic as before. Compare its duration with the standalone workflow's recent runs (3m19s to 4m53s on a warm layer cache, 9m39s after a lockfile change); the "Build Docker Image" step is replaced by a download and load of about 70 seconds. ### ADDITIONAL INFORMATION - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API 🤖 Generated with [Claude Code](https://claude.com/claude-code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
