rusackas commented on PR #45609: URL: https://github.com/apache/superset/pull/45609#issuecomment-6333869605
Numbers from this PR's run, next to the standalone workflow's recent master runs: | | standalone Chromatic, warm layer cache | standalone, after a lockfile change (#45603) | this PR | |---|---|---|---| | get the CI image | build 47 to 52 s | build 417 s | download 38 s + load 40 s | | Build Storybook | 108 to 130 s | 125 s | 116 s | | Publish to Chromatic | 23 to 29 s | 23 s | 25 s | | job | 3m19s to 4m53s | 9m39s | 3m57s | So on a warm layer cache this is a wash, give or take 30 seconds, and the win is the other case: any PR that touches the lockfile or a workspace manifest, which is every dependabot bump, goes from about 9.5 minutes to about 4. The one trade-off is that the job now waits for `frontend-build` instead of starting at push time, so on a quiet warm-cache run the Chromatic result lands a couple of minutes later than before. No standalone Chromatic run was triggered for this PR, so the deletion is doing its job. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
