veriiix commented on code in PR #45650: URL: https://github.com/apache/superset/pull/45650#discussion_r4421556905
########## pyproject.toml: ########## @@ -240,8 +240,10 @@ mariadb = ["apache-superset[mysql]"] monetdb = ["sqlalchemy-monetdb>=2.1.0, <3", "pymonetdb>=1.9.1, <2"] mongodb = ["pymongosql>=0.7.4, <1"] mssql = ["pymssql>=2.4.2, <3"] -# motherduck is an alias for duckdb - MotherDuck works via the duckdb driver -motherduck = ["apache-superset[duckdb]"] +# motherduck is an alias for duckdb - MotherDuck works via the duckdb driver. +# MotherDuck does not support DuckDB 2.x clients yet (max 1.5.6, see +# https://motherduck.com/docs/duckdb-versions.json), so keep it on <2. +motherduck = ["apache-superset[duckdb]", "duckdb<2"] Review Comment: Thanks @gabotorresruiz for confirming the split on 2.0.0. I'd prefer a follow-up. This PR is already reviewed and green, so keeping it to the dependency change makes it easy to review and easy to revert if needed. The docs update is a separate concern and fits better in its own PR. I'll open it after this merges and point the MotherDuck page at `apache-superset[motherduck]`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
