sfirke commented on issue #26651: URL: https://github.com/apache/superset/issues/26651#issuecomment-6367759455
Nice! I will try to deploy to a test environment early next week and kick the tires. Two minor things before that: 1) Instead of "2026-10-01 [less than or equal to] x [less than] 2026-12-01" showing as the selected range when they ended with 2026-11-30, what do you think about it displaying as ""2026-11-01 – 2026-11-30"? It seems weird to me that they pick Nov 30th and then see less than Dec 1st. I am not sure about this one, I've been thinking it through. Curious to hear what you and others think. 2) I don't feel strongly about bundling the "Part 1" of the discussion into this PR. In general I like smaller separate PRs when I'm working. But I don't feel strongly, it's big now with it but not impossibly so. But re: the config setting, I think that should ship with Part 1. So if your preference is to include Part 1 in the single PR, then please add the config flag. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
