CodeWithPravinMaske commented on issue #26651: URL: https://github.com/apache/superset/issues/26651#issuecomment-6398595749
@sfirke thanks. On your two points: 1) **Range display.** Agreed, picking Nov 30 and seeing "less than Dec 1" is confusing. I changed it: a Calendar range now shows the days that were picked, end day included (`2026-11-01 – 2026-11-30`). The exact range the backend applies (`2026-11-01 ≤ col < 2026-12-01`) stays in the tooltip. Nothing stored changes (the end is still saved as end + 1 day), only the label. A test covers it. 2) **Part 1 and the config setting.** The branch already includes the Calendar choice in the time range control (Part 1), so by your rule the config setting for the default of new filters should ship with it. I would rather not guess: do you prefer (a) I add the config flag in this PR, or (b) I split Part 1 into its own PR and keep this one to the checkbox only? I lean towards (b) since you like smaller PRs. I also merged the latest master into the branch. I'll hold on merging until the new SIP vote you described. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
