luth2 commented on code in PR #45823:
URL: https://github.com/apache/superset/pull/45823#discussion_r4431343640
##########
tests/unit_tests/commands/databases/columnar_reader_test.py:
##########
@@ -141,7 +141,7 @@ def test_excel_reader_wrong_columns_to_read():
with pytest.raises(DatabaseUploadFailed) as ex:
reader.file_to_dataframe(create_columnar_file(COLUMNAR_DATA))
assert (
- str(ex.value)
+ str(ex.value).replace(": large_string", ": string")
Review Comment:
Confirmed and fixed in 6b78fdb989. The expected Arrow schema now uses string
consistently with the existing large_string-to-string normalization on the
actual error. The full expected error is still checked, including the missing
xpto field. All 14 columnar-reader tests pass on Python 3.11/pandas 3.0.6 and
Python 3.15/pandas 3.1.0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
