luth2 commented on code in PR #45823:
URL: https://github.com/apache/superset/pull/45823#discussion_r4431939495
##########
superset/utils/pandas_postprocessing/histogram.py:
##########
@@ -75,7 +75,7 @@ def histogram(
return df
# convert to numeric, coercing errors to NaN
- df.loc[:, column] = to_numeric(df[column], errors="coerce")
+ df[column] = to_numeric(df[column], errors="coerce")
Review Comment:
Fixed in bc0bfdfd60 and revalidated for audit commit e8e1b5cf85. The
histogram regression explicitly builds both string and str Series from ["1",
"2", "3", "4"], calls bins=2, and requires counts [[2, 2]]. The full histogram
module passed on Python 3.11/pandas 3.0.6 and Python 3.15/pandas 3.1.0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
