luth2 commented on PR #45823: URL: https://github.com/apache/superset/pull/45823#issuecomment-6542205082
@sadpandajoe All five latest review findings are fixed in 6b78fdb989 and their threads have been answered and resolved. I also merged the latest master (1d0fc23b57) in 7acde2cf20; GitHub now confirms the branch is up to date and conflict-free. Post-merge local validation: 630 focused tests passed on Python 3.15/pandas 3.1.0, including temporal imports, joins, date normalization, columnar readers, pandas post-processing, result sets and the static OpenAPI tests. Scoped pre-commit hooks (including MyPy/Ruff and workflow security checks) and the POT drift check pass. Before this master merge, the four modules affected by the latest fixes also passed all 346 tests on each of Python 3.11/pandas 3.0.6 and Python 3.15/pandas 3.1.0. The remaining merge gates are the required code-owner approval and 24 workflows awaiting maintainer approval. Could a maintainer please approve the CI runs and re-review the updated PR? These local results are not a substitute for the pending hosted CI. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
