luth2 commented on code in PR #45823:
URL: https://github.com/apache/superset/pull/45823#discussion_r4431938347
##########
pyproject.toml:
##########
@@ -84,11 +84,13 @@ dependencies = [
"marshmallow-union>=0.1.15.post1",
"msgpack>=1.2.3, <1.3",
"nh3>=0.3.7, <0.4",
- "numpy>=1.23.5, <2.5",
+ "numpy>=1.23.5, <2.5; python_version < '3.15'",
+ "numpy>=2.5.4, <2.6; python_version >= '3.15'",
"packaging",
# --------------------------
# pandas and related (wanting pandas[performance] without numba as it's
100+MB and not needed)
- "pandas[excel]>=2.3.3, <2.4",
+ "pandas[excel]>=2.3.3, <2.4; python_version < '3.15'",
+ "pandas[excel]>=3.1.0, <3.2; python_version >= '3.15'",
Review Comment:
Validated as fixed; audit commit e8e1b5cf85. df_columns_to_num accepts
object and string dtypes using pandas dtype predicates. Its parametrized
regressions cover object/str/string columns, nullable values, numeric
aggregation and preservation of non-numeric labels. The complete
dataframe-utils module passed on Python 3.11/pandas 3.0.6 and Python
3.15/pandas 3.1.0.
##########
pyproject.toml:
##########
@@ -84,11 +84,13 @@ dependencies = [
"marshmallow-union>=0.1.15.post1",
"msgpack>=1.2.3, <1.3",
"nh3>=0.3.7, <0.4",
- "numpy>=1.23.5, <2.5",
+ "numpy>=1.23.5, <2.5; python_version < '3.15'",
+ "numpy>=2.5.4, <2.6; python_version >= '3.15'",
"packaging",
# --------------------------
# pandas and related (wanting pandas[performance] without numba as it's
100+MB and not needed)
- "pandas[excel]>=2.3.3, <2.4",
+ "pandas[excel]>=2.3.3, <2.4; python_version < '3.15'",
+ "pandas[excel]>=3.1.0, <3.2; python_version >= '3.15'",
Review Comment:
Fixed in bc0bfdfd60 and revalidated for audit commit e8e1b5cf85. Legacy
T/H/M/AS/A aliases are normalized to min/h/ME/YS/YE before validation and
resampling. All five offered legacy rules are compared against their modern
equivalents by regression tests. The complete resample module passed on both
Python/pandas baselines.
##########
superset/models/helpers.py:
##########
@@ -376,6 +376,8 @@ def _parse_temporal_join_values(series: pd.Series,
column_name: str) -> pd.Serie
"""Parse working temporal values and wrap pandas parser-policy errors."""
if pd.api.types.is_datetime64_any_dtype(series):
return series
+ if _has_multiple_utc_offsets(series):
Review Comment:
Fixed in bc0bfdfd60 and revalidated for audit commit e8e1b5cf85. Chart
datetime normalization retries mixed-timezone values in UTC while preserving
instants, then applies the requested display timezone. The Berlin repeated-hour
regression covers explicit and inferred formats with and without a display
timezone. All date-parsing tests passed on Python 3.11/pandas 3.0.6 and Python
3.15/pandas 3.1.0. The separate temporal-join path preserves local wall clocks,
as covered by the newer resolved review.
##########
superset/databases/api.py:
##########
@@ -1240,6 +1250,34 @@ def table_extra_metadata(self, pk: int) -> FlaskResponse:
return self.response(200, **payload)
@expose("/<int:pk>/select_star/<path:table_name>/", methods=("GET",))
+ @protect()
+ @permission_name("read")
+ def select_star_without_schema(self, pk: int, table_name: str) ->
FlaskResponse:
+ """Get a select star statement using the database's default schema.
+ ---
+ get:
+ summary: Get database select star for table in the default schema
+ parameters:
+ - in: path
+ schema:
+ type: integer
+ name: pk
+ description: The database id
+ - in: path
+ schema:
+ type: string
+ name: table_name
+ description: Table name
+ responses:
+ 200:
+ description: SQL statement for a select star for table
+ content:
+ application/json:
+ schema:
+ $ref: "#/components/schemas/SelectStarResponseSchema"
Review Comment:
Fixed in bc0bfdfd60 and revalidated for audit commit e8e1b5cf85. The
schema-free wrapper documents 400/401/404/422/500 responses alongside 200, and
the published OpenAPI artifact was regenerated. The static-spec regression
checks every required error reference on this exact route; both static-spec
tests pass on Python 3.11 and 3.15.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
