etr2460 commented on a change in pull request #9054: [database] new, select star API migration URL: https://github.com/apache/incubator-superset/pull/9054#discussion_r374841504
########## File path: superset/views/core.py ########## @@ -1958,11 +1958,26 @@ def extra_table_metadata(self, database_id, table_name, schema): @expose("/select_star/<database_id>/<table_name>/<schema>") @event_logger.log_this def select_star(self, database_id, table_name, schema=None): - mydb = db.session.query(models.Database).get(database_id) + logging.warning( + "This API endpoint is deprecated and will be removed in version 1.0.0" Review comment: Thanks @dpgaspar! do you think these should be prefixed by `deprecated_function_call` or something like that? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org