dpgaspar commented on a change in pull request #9054: [database] new, select
star API migration
URL:
https://github.com/apache/incubator-superset/pull/9054#discussion_r374842848
##########
File path: superset/views/base_api.py
##########
@@ -122,6 +122,9 @@ def _get_related_filter(self, datamodel, column_name: str,
value: str) -> Filter
)
return filters
+ def incr_stats(self, action: str, func_name: str) -> None:
+
self.stats_logger.incr(f"{action}_{self.__class__.__name__}.{func_name}")
Review comment:
I'm ok with it, the goal here is to pave the way to have a consistent statsd
metric name. btw on some monitoring systems you can't make glob-based
selections, for example using wildcards.
Hoping to have some feedback on @etr2460 on this naming convention, the
current one does not diverge a lot from the current metric names, that's why
the action comes first.
I do prefer your way, makes more sense
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
