dpgaspar commented on a change in pull request #9054: [database] new, select
star API migration
URL:
https://github.com/apache/incubator-superset/pull/9054#discussion_r375163447
##########
File path: superset/views/core.py
##########
@@ -1958,11 +1958,26 @@ def extra_table_metadata(self, database_id,
table_name, schema):
@expose("/select_star/<database_id>/<table_name>/<schema>")
@event_logger.log_this
def select_star(self, database_id, table_name, schema=None):
- mydb = db.session.query(models.Database).get(database_id)
+ logging.warning(
+ "This API endpoint is deprecated and will be removed in version
1.0.0"
Review comment:
Could be useful on your side. So I've made a few changes (following
@robdiciuccio comment):
metrics are now:
deprecated.Superset.select_star.init
deprecated.Superset.select_star.database_not_found
deprecated.Superset.select_star.permission_denied
deprecated.Superset.select_star.success
DatabaseRestApi.select_star.init
DatabaseRestApi.select_star.database_not_found
DatabaseRestApi.select_star.permission_denied
DatabaseRestApi.select_star.success
DatabaseRestApi.table_metada.init
DatabaseRestApi.table_metada.database_not_found
DatabaseRestApi.table_metada.permission_denied
DatabaseRestApi.table_metada.success
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
