villebro opened a new pull request #9316: fix: remove character set and collate column info by default URL: https://github.com/apache/incubator-superset/pull/9316 ### CATEGORY Choose one - [x] Bug Fix - [ ] Enhancement (new features, refinement) - [x] Refactor - [x] Add tests - [ ] Build / Development Environment - [ ] Documentation ### SUMMARY It is common for SQL engines to offer the option to define a custom character set and collation scheme for columns. The convention is to define this using the following syntax (example from MySQL): `VARCHAR(255) CHARACTER SET LATIN1 COLLATE UTF8MB4_GENERAL_CI`. A few examples: - https://dev.mysql.com/doc/refman/8.0/en/charset-column.html - https://docs.oracle.com/cd/E17952_01/mysql-5.1-en/charset-column.html Currently Superset already removes collation info, but retains the character set info. This often causes an overflow when saving metadata due to the column type only being 32 characters wide. This PR makes removal of collation and character set info the new default behaviour. ### TEST PLAN Local test + CI ### ADDITIONAL INFORMATION - [x] Has associated issue: closes #5018 - [ ] Changes UI - [ ] Requires DB Migration. - [ ] Confirm DB Migration upgrade and downgrade tested. - [ ] Introduces new feature or API - [ ] Removes existing feature or API ### REVIEWERS @john-bodley @mistercrunch
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
