villebro edited a comment on issue #9316: fix: remove character set and collate column info by default URL: https://github.com/apache/incubator-superset/pull/9316#issuecomment-600065555 @john-bodley what you're saying makes total sense. The columns from which these strings are created are constructed here: https://github.com/apache/incubator-superset/blob/85e9a4fa990927327755f5743317e848fc230f01/superset/models/core.py#L577-L586 I'm thinking we should loop through these columns prior to returning the `Table` instance, and remove collation and character set details if present. Do yo agree? **Edit**: on second thought best to not mutate the original table, probably wise to do in `db_engine_spec.column_datatype_to_string` instead
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
