villebro edited a comment on issue #9316: fix: remove character set and collate 
column info by default
URL: 
https://github.com/apache/incubator-superset/pull/9316#issuecomment-600216451
 
 
   @john-bodley right now the column type column is `VARCHAR(32)`, aka. they 
overflow and cause an exception when adding a new table. We could potentially 
make the column wider, say `VARCHAR(100)`, which would solve the problem, but 
wouldn't really add any value other than the edge case where someone wants to 
quickly check the collation in Superset (probably not a common use case). So I 
guess it comes down to removing the additional info to avoid having to make a 
metadata migration and keeping the type column slightly lighter in the table 
editor, or just making it wider and providing the users more context of the 
column types.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to