villebro commented on a change in pull request #9316: fix: remove character set
and collate column info by default
URL:
https://github.com/apache/incubator-superset/pull/9316#discussion_r393364894
##########
File path: superset/db_engine_specs/base.py
##########
@@ -161,6 +161,7 @@ class BaseEngineSpec: # pylint:
disable=too-many-public-methods
utils.DbColumnType.STRING: (
re.compile(r".*CHAR.*", re.IGNORECASE),
re.compile(r".*STRING.*", re.IGNORECASE),
+ re.compile(r".*TEXT.*", re.IGNORECASE),
Review comment:
This is mostly unrelated to this PR, but I noticed that the `TEXT` types
were not being identified as string column types (I'm surprised this hadn't
come up previously).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
