john-bodley commented on a change in pull request #9396: feat: add SSL 
certificate validation for Druid
URL: 
https://github.com/apache/incubator-superset/pull/9396#discussion_r398635854
 
 

 ##########
 File path: superset/utils/core.py
 ##########
 @@ -1163,6 +1166,26 @@ def get_username() -> Optional[str]:
         return None
 
 
+def create_temporary_ssl_cert_file(certificate: str) -> str:
 
 Review comment:
   This doesn’t feel temporary to me. Maybe the method and docstring should be 
updated.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to