dpgaspar commented on a change in pull request #9396: feat: add SSL certificate
validation for Druid
URL:
https://github.com/apache/incubator-superset/pull/9396#discussion_r398803213
##########
File path: superset/views/database/mixins.py
##########
@@ -196,6 +204,9 @@ def _pre_add_update(self, database):
check_sqlalchemy_uri(database.sqlalchemy_uri)
self.check_extra(database)
self.check_encrypted_extra(database)
+ database.server_cert = (
+ database.server_cert.strip() if database.server_cert else ""
+ )
Review comment:
"server_cert" is not being validated before persisting to the DB, are we
relying on `testconn`. It would be nice to add `parse_ssl_cert` to the pre_add,
pre_update hooks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
