villebro commented on a change in pull request #9396: feat: add SSL certificate
validation for Druid
URL:
https://github.com/apache/incubator-superset/pull/9396#discussion_r398714482
##########
File path: superset/db_engine_specs/base.py
##########
@@ -959,3 +959,15 @@ def mutate_db_for_connection_test(database: "Database")
-> None:
:param database: instance to be mutated
"""
return None
+
+ @staticmethod
+ def mutate_connection_args(
+ database: "Database", connect_args: Dict[str, Any]
+ ) -> None:
+ """
+ Some databases require passing additional non-standard parameters to
database
+ connections, for example client certificates.
+
+ :param database: instance to be mutated
Review comment:
Yes, or more specifically it's in `database.extra`, which is in JSON format.
The reason it's being passed as a separate argument is that it's already been
parsed out of `extra`. We could optionally inject this into `extra`, too, but
that might be more confusing, as then we'd have to `json.parse`, mutate and
`json.dumps` again.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
