dpgaspar commented on a change in pull request #9396: feat: add SSL certificate
validation for Druid
URL:
https://github.com/apache/incubator-superset/pull/9396#discussion_r398793310
##########
File path: superset/db_engine_specs/base.py
##########
@@ -959,3 +963,20 @@ def mutate_db_for_connection_test(database: "Database")
-> None:
:param database: instance to be mutated
"""
return None
+
+ @staticmethod
+ def get_extra_params(database: "Database") -> Dict[str, Any]:
+ """
+ Some databases require adding elements to connection parameters,
+ like passing certificates to `extra`. This can be done here.
+
+ :param database: database instance from which to extract extras
+ """
Review comment:
nit: it's nice to add a `:raises:` on the docstring when a method can raise
an exception
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
