dpgaspar commented on a change in pull request #9396: feat: add SSL certificate
validation for Druid
URL:
https://github.com/apache/incubator-superset/pull/9396#discussion_r398793825
##########
File path: superset/db_engine_specs/druid.py
##########
@@ -47,3 +52,26 @@ class DruidEngineSpec(BaseEngineSpec): # pylint:
disable=abstract-method
def alter_new_orm_column(cls, orm_col: "TableColumn") -> None:
if orm_col.column_name == "__time":
orm_col.is_dttm = True
+
+ @staticmethod
+ def get_extra_params(database: "Database") -> Dict[str, Any]:
+ """
+ For Druid, the path to a SSL certificate is placed in `connect_args`.
+
+ :param database: database instance from which to extract extras
Review comment:
nit: it's nice to add a :raises: on the docstring when a method can raise an
exception
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
