john-bodley commented on a change in pull request #9418: [mypy] Enforcing
typing for superset.dashboards
URL:
https://github.com/apache/incubator-superset/pull/9418#discussion_r400347696
##########
File path: superset/dashboards/commands/bulk_delete.py
##########
@@ -40,7 +40,7 @@ def __init__(self, user: User, model_ids: List[int]):
self._model_ids = model_ids
self._models: Optional[List[Dashboard]] = None
- def run(self):
+ def run(self) -> None:
Review comment:
I prefer the later, i.e., all the `run` signatures having the same return
type. It helps to ensures consistency both now and for future classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
