villebro commented on a change in pull request #9418: [mypy] Enforcing typing
for superset.dashboards
URL:
https://github.com/apache/incubator-superset/pull/9418#discussion_r402264733
##########
File path: superset/dashboards/commands/create.py
##########
@@ -38,7 +39,7 @@ def __init__(self, user: User, data: Dict):
self._actor = user
self._properties = data.copy()
- def run(self):
+ def run(self) -> Optional[Model]:
Review comment:
Isn't `BaseDAO.create` returning `Model`, ie. this should also do the same?
And if so, the changes above should probably also reflect this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
