villebro commented on a change in pull request #9418: [mypy] Enforcing typing
for superset.dashboards
URL:
https://github.com/apache/incubator-superset/pull/9418#discussion_r402267027
##########
File path: superset/dashboards/commands/delete.py
##########
@@ -40,7 +41,7 @@ def __init__(self, user: User, model_id: int):
self._model_id = model_id
self._model: Optional[Dashboard] = None
- def run(self):
+ def run(self) -> Optional[Model]:
Review comment:
`BaseDAO.delete` seems to always return `Model` (this should be added to the
signature in `superset/dao/base/BaseDAO.delete`), ie. this should also do the
same?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
