villebro commented on a change in pull request #9418: [mypy] Enforcing typing
for superset.dashboards
URL:
https://github.com/apache/incubator-superset/pull/9418#discussion_r402258513
##########
File path: superset/charts/commands/update.py
##########
@@ -46,7 +46,7 @@ def __init__(self, user: User, model_id: int, data: Dict):
self._actor = user
self._model_id = model_id
self._properties = data.copy()
- self._model: Optional[SqlaTable] = None
+ self._model: Optional[Slice] = None
Review comment:
Whoa++
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
