[GitHub] [incubator-superset] ktmud commented on a change in pull request #9628: feat: upgrade react-select and make multi-select sortable

Thu, 07 May 2020 19:26:26 -0700 


ktmud commented on a change in pull request #9628:
URL: 
https://github.com/apache/incubator-superset/pull/9628#discussion_r421899928



##########
File path: superset-frontend/src/visualizations/FilterBox/FilterBox.less
##########
@@ -18,35 +18,10 @@
  */
 @import '../../../stylesheets/less/variables.less';
 
-.select2-highlighted > .filter_box {
-  background-color: transparent;
-  border: 1px superset @darkest;
-}

Review comment:
       `select2` is obviously not used anymore.

##########
File path: superset-frontend/src/explore/main.less
##########
@@ -106,14 +98,16 @@
   float: left;
   padding-right: 3px;
 
-  .Select-control {
+  .dropdown {
     display: flex;
-
-    .Select-arrow-zone {
-      width: auto;
-      position: absolute;
-      right: 0;
-      top: 12px;
+    button {
+      padding-right: 20px;
+      .caret {
+        width: auto;
+        position: absolute;
+        right: 5px;
+        top: 6px;
+      }

Review comment:
       This is for fixing some styles in date selector:
   
   ### Before
   
   
![image](https://user-images.githubusercontent.com/335541/81363494-5133cf00-9098-11ea-8d98-1f711b1aef55.png)
   
   
   ### After
   
   
![image](https://user-images.githubusercontent.com/335541/81363549-745e7e80-9098-11ea-8ca4-9eb5393b0532.png)
   
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to