ktmud commented on a change in pull request #9628:
URL:
https://github.com/apache/incubator-superset/pull/9628#discussion_r424642916
##########
File path: superset-frontend/src/components/ListView/LegacyFilters.tsx
##########
@@ -67,9 +63,10 @@ export const FilterMenu = ({
<MenuItem
key={ft.id}
eventKey={ft}
- onSelect={(fltr: typeof ft) =>
- setInternalFilters([...internalFilters, fltr])
- }
+ // @ts-ignore
Review comment:
> Type 'MouseEvent<{}, MouseEvent>' is missing the following properties
from type '{ Header: string; id: string; value: undefined; }': Header, id, value
Inconsistent callback function signature. onSelect in MenuItem expects an
event, but the callback seems to be expecting the fltr type.
Didn't want to change the actual code and didn't dig too deep into how to
make it proper, since this file is going to be deprecated anyway (@nytai is
working on a new ListView).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
