nytai commented on a change in pull request #9628:
URL:
https://github.com/apache/incubator-superset/pull/9628#discussion_r424716193
##########
File path: superset-frontend/src/components/ListView/LegacyFilters.tsx
##########
@@ -67,9 +63,10 @@ export const FilterMenu = ({
<MenuItem
key={ft.id}
eventKey={ft}
- onSelect={(fltr: typeof ft) =>
- setInternalFilters([...internalFilters, fltr])
- }
+ // @ts-ignore
Review comment:
The issue is the typings for react-bootstrap. If EventKey is present the
callback will be called with that and not a MouseEvent, but the typings don't
seem to account for that. This code is all going away soon, anyway, I wouldn't
spend too much time on it
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
