nytai commented on a change in pull request #9628:
URL:
https://github.com/apache/incubator-superset/pull/9628#discussion_r424714108
##########
File path: superset-frontend/src/components/ListView/LegacyFilters.tsx
##########
@@ -67,9 +63,10 @@ export const FilterMenu = ({
<MenuItem
key={ft.id}
eventKey={ft}
- onSelect={(fltr: typeof ft) =>
- setInternalFilters([...internalFilters, fltr])
- }
+ // @ts-ignore
Review comment:
Yes, this is old code that's going to be killed soon. I think
react-bootstrap was missing proper typings when this was being implemented so
some type is probably being overridden incorrectly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
