graceguo-supercat commented on pull request #9817: URL: https://github.com/apache/incubator-superset/pull/9817#issuecomment-630393813
My point is this quick save makes Save behavior inconsistent. Auto save is a standard behavior for many application. If we want to offer auto-save, the behavior should be consistent, all the changes should have auto-saved. Click and save is another set of standard behavior, it also used by many application. But mix this 2 may make user will feel sometimes Superset can auto save their change without they click anything, but sometimes not. Only developer read the code will find out the subtle difference. The inconsistency will bring more confusion than very little connivence. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
