graceguo-supercat edited a comment on pull request #9817: URL: https://github.com/apache/incubator-superset/pull/9817#issuecomment-630393813
My point is this quick save makes Save behavior inconsistent. - _Auto-save_ is a standard behavior for many application. If we want to offer auto-save, the behavior should be consistent, all the changes should have auto-saved. - _Click-and-save_ is another set of standard behavior, it also used by many applications. But mix this 2 may make user will feel sometimes Superset can auto save their change without they click anything, but sometimes not. Only developer read the code will find out the subtle difference. - Even we offer quiet auto-save, user may still feel uncertain after they have all the edit work done. So they will still want to click save button to re-assure all their work is saved. So the quick auto-save a middle copy is not necessary. The inconsistency will bring more confusion than very little connivence. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
