graceguo-supercat commented on a change in pull request #10275:
URL:
https://github.com/apache/incubator-superset/pull/10275#discussion_r455232607
##########
File path: superset-frontend/src/SqlLab/components/TabbedSqlEditors.jsx
##########
@@ -289,9 +290,13 @@ class TabbedSqlEditors extends React.PureComponent {
const title = (
<>
{qe.title} <TabStatusIcon tabState={state} />{' '}
- <span className="close" onClick={() => this.removeQueryEditor(qe)}>
- {'×'}
- </span>
+ <Icon
+ name="cancel-x"
+ height="16px"
+ width="16px"
Review comment:
It turn out all these extra props are not necessary...i thought new icon
pushed the tab taller but actually not. new svg (with 24 x 14) is good to use.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
