graceguo-supercat commented on a change in pull request #10275:
URL:
https://github.com/apache/incubator-superset/pull/10275#discussion_r455233531
##########
File path: superset-frontend/src/SqlLab/main.less
##########
@@ -259,6 +259,22 @@ div.Workspace {
&:active {
background: none;
}
+
+ .fa.fa-close {
Review comment:
correct. this PR can't handle big issue like that. no one will care
there is an icon in whole Superset is a11y. yay!!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
