etr2460 commented on a change in pull request #10634:
URL:
https://github.com/apache/incubator-superset/pull/10634#discussion_r473212529
##########
File path: superset-frontend/webpack.config.js
##########
@@ -256,7 +257,7 @@ const config = {
{
test: /\.jsx?$/,
// include source code for plugins, but exclude node_modules within
them
Review comment:
let's update the comment to `exclude node_modules and tests within them`
##########
File path: superset-frontend/webpack.config.js
##########
@@ -230,6 +230,7 @@ const config = {
},
{
test: /\.tsx?$/,
+ exclude: [/\.test.tsx?$/],
Review comment:
Maybe make this exclude `.test.jsx` too since there's a decent chance we
might move files around before converting them to TS?
##########
File path: superset-frontend/src/components/Label/Label.stories.tsx
##########
@@ -25,9 +25,10 @@ export default {
title: 'Label',
component: Label,
decorators: [withKnobs],
+ excludeStories: ['bsStyleKnob'],
};
-const bsStyleKnob = {
+export const bsStyleKnob = {
Review comment:
maybe we should move this to a fixtures file that the stories and the
test can both import from? It's a bit weird to import from a stories file in
the test file, and it would also mean you don't need to tell storybook that
this isn't a story too
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
