rusackas commented on pull request #10634: URL: https://github.com/apache/incubator-superset/pull/10634#issuecomment-676578666
> a few comments, but nothing really blocking. this seems like a decent approach to follow going forward, but i'd further reiterate my concern that if we can't do a full migration to this new structure quickly, it'll cause a bunch of confusion for contributors trying to add unit tests Agreed on the concern... I'm trying to find a good way to _reduce_ the confusion I've already encountered. Right now, it does open up another path, but I'm going to sweep through a bunch of components to follow this pattern and move existing tests, so it becomes more prevalent/obvious. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
