rusackas commented on a change in pull request #10634:
URL:
https://github.com/apache/incubator-superset/pull/10634#discussion_r473222258
##########
File path: superset-frontend/src/components/Label/Label.stories.tsx
##########
@@ -25,9 +25,10 @@ export default {
title: 'Label',
component: Label,
decorators: [withKnobs],
+ excludeStories: ['bsStyleKnob'],
};
-const bsStyleKnob = {
+export const bsStyleKnob = {
Review comment:
In this case (exporting the knobs), I agree it's a little weird, but I
really like importing the actual _stories_ in tests, so I figured this could
come along for the ride. Mounting the story exports helps make sure your tests
cover the use cases of the component properly, and means that storybook edits
(i.e. when adding new features/variants to a component) might cause test
failures, which I think is a _good_ thing.
All that being said, I'll try to find a good way around the weird knob
export/exclusion (probably in another PR). It is a little screwy.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
