eschutho commented on a change in pull request #10847:
URL:
https://github.com/apache/incubator-superset/pull/10847#discussion_r488257207
##########
File path: superset-frontend/cypress-base/package.json
##########
@@ -3,7 +3,7 @@
"version": "1.0.0",
"description": "run cypress against superset",
"scripts": {
- "cypress": "cypress",
+ "cypress": "CYPRESS_BASE_URL=\"http://localhost:${npm_config_port:-8088}\";
cypress",
Review comment:
This isn't necessary, but an extra addition to potentially minimize
confusion for engineers that have an existing cypress test workflow and aren't
running on port 8088. You would overwrite the default with something like `npm
run cypress open --port=8090`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
