ktmud commented on pull request #10847: URL: https://github.com/apache/incubator-superset/pull/10847#issuecomment-692349416
I think the point of the `CYPRESS_BASE_URL` variable is that you can override it ad-hoc. It doesn't feel right to me to bake it into a fixed value in CI/NPM scripts. This would make it impossible to override it outside of the running script. Would adding instructions of how to set `CYPRESS_BASE_URL` to `CONTRIBUTING.md` or [docker/README.md](https://github.com/apache/incubator-superset/blob/master/docker/README.md) suffice to reduce confusions? ```bash cd cypress-base CYPRESS_BASE_URL=http://localhost:8088 npm run cypress-debug ``` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
