eschutho commented on pull request #10847: URL: https://github.com/apache/incubator-superset/pull/10847#issuecomment-692954636
@ktmud yes, adding it to the docs would definitely reduce confusion. What do you feel about the extra task of setting the var each time to you run the npm script? Do you think the abstraction to have a default value preset, but still allowing a port override is helpful? I suppose some engs will resort to creating a bash alias if they use this script a lot and have to set the port each time. Second question is around CI and tox.. I feel like setting the port closer in the script to where the port is set makes this less brittle, but curious to hear your thought on that, too. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
