ktmud commented on pull request #10847: URL: https://github.com/apache/incubator-superset/pull/10847#issuecomment-693004920
I agree it'd be very beneficial to make sure the default ports are consistent across places. I'm on board with changing the default port for Cypress if that means more consistency with Docker, default Flask port, `npm run dev-server` and anywhere else mentioned in the document. Yeah, I agree setting the port closer to the CI script makes things less brittle, which is why I feel it's probably not necessary to set `CYPRESS_BASE_URL` in `package.json`. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
