michael-s-molina opened a new pull request #12010: URL: https://github.com/apache/incubator-superset/pull/12010
### SUMMARY Removes all [anchor-is-valid](https://github.com/jsx-eslint/eslint-plugin-jsx-a11y/blob/master/docs/rules/anchor-is-valid.md) lint warnings. All anchor tags that were being used as a button and not making use of `href` were replaced by a similar component. A component called `Link` were always being used as an icon button and no valid `href` so I renamed to `IconTooltip`. We already have a `Link` component in `react-router-dom`. Another benefit of this change is that the icon buttons now have their colors provided by Emotion using the theme. I noticed that some of the icons are coming from images/icons and some are coming from bootstrap classes. When we unify all this we can create an icon property in IconTooltip of a type available in images/icons. For now I kept the use of class names for icon definition. I revised all the interfaces affected by this change to make sure the interaction remained the same. There were some minor changes like no underscore in icon buttons and lighter base/hover colors that came from the theme. ### ADDITIONAL INFORMATION - [ ] Has associated issue: - [x] Changes UI - [ ] Requires DB Migration. - [ ] Confirm DB Migration upgrade and downgrade tested. - [ ] Introduces new feature or API - [ ] Removes existing feature or API ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
