rusackas commented on a change in pull request #12010:
URL:
https://github.com/apache/incubator-superset/pull/12010#discussion_r541191419
##########
File path: superset-frontend/src/datasource/DatasourceEditor.jsx
##########
@@ -790,12 +790,12 @@ class DatasourceEditor extends React.PureComponent {
</Fieldset>
{this.allowEditSource && (
<EditLockContainer>
- <a href="#" onClick={this.onChangeEditMode}>
+ <span role="button" tabIndex={0} onClick={this.onChangeEditMode}>
Review comment:
Does this still show the 👆 cursor on hover? If not, that would be nice :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
