rusackas commented on a change in pull request #12010:
URL:
https://github.com/apache/incubator-superset/pull/12010#discussion_r541203076
##########
File path: superset-frontend/spec/javascripts/sqllab/IconTooltip_spec.jsx
##########
@@ -18,22 +18,24 @@
*/
import React from 'react';
import { shallow } from 'enzyme';
+import { Tooltip } from 'src/common/components/Tooltip';
+import IconTooltip from 'src/components/IconTooltip';
-import Link from 'src/components/Link';
-
-describe('Link', () => {
+describe('IconTooltip', () => {
const mockedProps = {
tooltip: 'This is a tooltip',
href: 'https://www.airbnb.com',
Review comment:
It _looks like_ with the new changes to IconTooltip, this href isn't
used anywhere. The tests don't assert against it, so perhaps they should?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
