rusackas commented on a change in pull request #12010:
URL:
https://github.com/apache/incubator-superset/pull/12010#discussion_r541214357
##########
File path: superset-frontend/src/components/IconTooltip.tsx
##########
@@ -69,11 +74,11 @@ const Link = ({
mouseEnterDelay={0.3}
mouseLeaveDelay={0.15}
>
- {link}
+ {iconTooltip}
</Tooltip>
);
}
- return link;
+ return iconTooltip;
};
-export default Link;
+export default IconTooltip;
Review comment:
personally, I prefer named exports to better encourage uniform
naming/usage on the import side... but this isn't your fault, and I'm not sure
if it's worth changing here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
