nytai commented on a change in pull request #12694:
URL: https://github.com/apache/superset/pull/12694#discussion_r564140702



##########
File path: .asf.yaml
##########
@@ -52,3 +52,24 @@ github:
     squash: true
     merge: false
     rebase: false
+
+  protected_branches:
+    master:
+      required_status_checks:
+        # strict means "Require branches to be up to date before merging".
+        strict: false
+        # contexts are the names of checks that must pass
+        contexts:
+          - Docker/build
+          - Frontend/build
+          - PR Lint/check
+          - E2E/Cypress
+          - Python Misc/lint
+          - Python MySQL/test-mysql
+          - Python MySQL/test-postgres
+          - Python MySQL/test-sqlite

Review comment:
       I found a few other projects using this feature
   https://github.com/apache/skywalking-eyes/blob/main/.asf.yaml
   https://github.com/apache/skywalking/blob/master/.asf.yaml
   https://github.com/apache/skywalking-python/blob/master/.asf.yaml
   
   It seems they're using the portion after the `/`, which would result in 
duplicates for us. I think this looks good to me




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to