eschutho commented on a change in pull request #12694:
URL: https://github.com/apache/superset/pull/12694#discussion_r564136646
##########
File path: .asf.yaml
##########
@@ -52,3 +52,24 @@ github:
squash: true
merge: false
rebase: false
+
+ protected_branches:
+ master:
+ required_status_checks:
+ # strict means "Require branches to be up to date before merging".
+ strict: false
+ # contexts are the names of checks that must pass
+ contexts:
+ - Docker/build
+ - Frontend/build
+ - PR Lint/check
+ - E2E/Cypress
+ - lint
+ - test-mysql
+ - test-postgres
+ - test-sqlite
Review comment:
Following on this scenario, do you think all the "blocked" prs would
automatically be mergable after we revert this? Do you think there's any risk
that we won't be able to unblock them? I think worst case scenario, we should
be able to close and open the pr to retrigger the checks, which would just be
time consuming.
##########
File path: .asf.yaml
##########
@@ -52,3 +52,24 @@ github:
squash: true
merge: false
rebase: false
+
+ protected_branches:
+ master:
+ required_status_checks:
+ # strict means "Require branches to be up to date before merging".
+ strict: false
+ # contexts are the names of checks that must pass
+ contexts:
+ - Docker/build
+ - Frontend/build
+ - PR Lint/check
+ - E2E/Cypress
+ - Python Misc/lint
+ - Python MySQL/test-mysql
+ - Python MySQL/test-postgres
+ - Python MySQL/test-sqlite
Review comment:
@nytai @ktmud Do we feel comfortable with this list or do we want to use
the api response instead?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
