nytai commented on a change in pull request #12694:
URL: https://github.com/apache/superset/pull/12694#discussion_r564228607



##########
File path: .asf.yaml
##########
@@ -52,3 +52,24 @@ github:
     squash: true
     merge: false
     rebase: false
+
+  protected_branches:
+    master:
+      required_status_checks:
+        # strict means "Require branches to be up to date before merging".
+        strict: false
+        # contexts are the names of checks that must pass
+        contexts:
+          - Docker/build
+          - Frontend/build
+          - PR Lint/check
+          - E2E/Cypress
+          - Python Misc/lint
+          - Python MySQL/test-mysql
+          - Python MySQL/test-postgres
+          - Python MySQL/test-sqlite

Review comment:
       When you go to settings you can't just enter any string, you have to 
choose from the list of "status checks found in the last week for this 
repository". I think it needs to be a context the repo has seen before. Also, 
here they have `build` set but no check is marked as required.
   
https://github.com/apache/skywalking-client-js/blob/04dd6b3b024f838b3b92002a370ce3b7f70638b4/.asf.yaml#L38




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to