[GitHub] [superset] ktmud commented on a change in pull request #12694: chore: add required review on master

[GitBox]

ktmud commented on a change in pull request #12694:
URL: https://github.com/apache/superset/pull/12694#discussion_r564406497



##########
File path: .asf.yaml
##########
@@ -52,3 +52,24 @@ github:
     squash: true
     merge: false
     rebase: false
+
+  protected_branches:
+    master:
+      required_status_checks:
+        # strict means "Require branches to be up to date before merging".
+        strict: false
+        # contexts are the names of checks that must pass
+        contexts:
+          - Docker/build
+          - Frontend/build
+          - PR Lint/check
+          - E2E/Cypress
+          - Python Misc/lint
+          - Python MySQL/test-mysql
+          - Python MySQL/test-postgres
+          - Python MySQL/test-sqlite

Review comment:
       Tested with [a personal 
fork](https://github.com/NUDA5020/superset/pull/1), now I'm 90% sure GitHub 
will just be forever waiting for these unidentifiable checks:
   
   <img width="954" alt="API request" 
src="https://user-images.githubusercontent.com/335541/105833261-ca07ed80-5f7d-11eb-875d-cd1d6af9b9f4.png";>
   
   <img width="975" alt="settings" 
src="https://user-images.githubusercontent.com/335541/105833271-cecca180-5f7d-11eb-97af-2eb9e2b6b2f9.png";>
   
   <img width="963" alt="random-checks" 
src="https://user-images.githubusercontent.com/335541/105833304-d9873680-5f7d-11eb-964d-a717a46f4e9f.png";>
   
   
   IMO the safest course of actions is:
   
   1. Update this PR to include only the simplest check (e.g. "PR Lint") in the 
required list, just to override manual admin settings.
   2. Once the CI passes, merge it.
   3. Make another PR to rename the jobs with ambiguous names
   4. Maybe another PR to add other required checks back to the "required" 
list. Could combine with 3, too.
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org