ktmud edited a comment on pull request #12903:
URL: https://github.com/apache/superset/pull/12903#issuecomment-772933451


   > I would think collapsing it rather than completely removing it from the UI 
would make this less confusing for users. Removing based on no temporal fields 
is also relying heavily on the automatic detection or manual identification of 
these fields, which may be inaccurate or not set correctly. Not displaying the 
UI at all may lead the user to believe that filtering by time range is not 
possible at all in a visualization.
   
   1. Currently users have to select "Is temporal" for a column to appear in 
the Time Column select. So this inference is at least guaranteed to be 
consistent with the Time column choices.
   2. If the Time column choice is empty, then filtering by time range is 
indeed impossible for the specific chart, right?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to