rusackas commented on pull request #12903:
URL: https://github.com/apache/superset/pull/12903#issuecomment-773005024
Late to the party, but I want to echo a few sentiments:
> ... is relying heavily on the automatic detection or manual identification
of these fields
This concern immediately popped into my head. We should audit and/or add
unit tests as needed to make that bulletproof for every format of temporal data
we intend to support.
Additionally, I would prefer there to be _something_ in place of just hiding
controls. In agreement that an action to "add or assign temporal columns" would
be hugely valuable.
If, hoever, adding that link/flow merits a separate PR or design cycle, we
could show the temporal controls header and include a "no temporal columns
available" message to at least _indicate_ that this functionality is available
for this chart type. A tooltip there explaining the user's options to add the
column would get us even closer in terms of usability.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
